lkml.org 
[lkml]   [2016]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver
On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.t@hotmail.com>

You do not need this From: line here. The email From: header is
sufficient.

>
> Fixes following coading style issues reported by the check patch script.
> - ERROR: Macros with complex values should be enclosed in parentheses
> - CHECK: struct mutex definition without comment
> - CHECK: spinlock_t definition without comment
> - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code
> rather than BUG() or BUG_ON()
> - WARNING: storage class should be at the beginning of the declaration

You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.

regards
sudip

\
 
 \ /
  Last update: 2016-01-29 19:01    [W:0.155 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site