Messages in this thread Patch in this message | | | From | Saurabh Sengar <> | Subject | [PATCH] QE: Use GFP_ATOMIC while spin_lock_irqsave is held | Date | Sun, 24 Jan 2016 12:24:06 +0530 |
| |
cpm_muram_alloc_common is called twice and both the times spin_lock_irqsave is held. Using GFP_KERNEL can sleep in spin_lock_irqsave context and cause deadlock
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> --- Let me know if there is any other way to fix it. Also, I would say this function should be static as it is not used in any other file drivers/soc/fsl/qe/qe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c index 419fa5b..d774e54 100644 --- a/drivers/soc/fsl/qe/qe_common.c +++ b/drivers/soc/fsl/qe/qe_common.c @@ -194,7 +194,7 @@ unsigned long cpm_muram_alloc_common(unsigned long size, genpool_algo_t algo, goto out2; start = start - GENPOOL_OFFSET; memset_io(cpm_muram_addr(start), 0, size); - entry = kmalloc(sizeof(*entry), GFP_KERNEL); + entry = kmalloc(sizeof(*entry), GFP_ATOMIC); if (!entry) goto out1; entry->start = start; -- 1.9.1
| |