Messages in this thread | | | From | Pali Rohár <> | Subject | Nokia N900: twl4030-power different data in DTS and board code | Date | Sat, 2 Jan 2016 15:13:32 +0100 |
| |
Hello,
now I'm looking at differences between legacy board code and DTS file for Nokia N900 and I see some inconsistency for twl4030-power driver.
In board code are defined more twl4030 power scripts which override defaults defined in twl4030-power code. See:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mach-omap2/board-rx51-peripherals.c#n790
Next in DTS file is defined just "compatible" keyword, but no custom scripts, see:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/omap3-n900.dts#n416
And the last in DTS file is defined line:
compatible = "ti,twl4030-power-n900"
which is not in twl4030-power driver itself, see:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/mfd/twl4030-power.c#n851
So all this stuff looks like some errors when board code was ported to DTS. Tony, can you look at this at all?
-- Pali Rohár pali.rohar@gmail.com [unhandled content-type:application/pgp-signature] | |