lkml.org 
[lkml]   [2015]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 5/5] perf probe: Print deleted events in cmd_probe()
On Fri, Sep 04, 2015 at 11:46:45AM +0000, 平松雅巳 / HIRAMATU,MASAMI wrote:
> > From: Namhyung Kim [mailto:namhyung@kernel.org]
> >
> > Showing actual trace event when deleteing perf events is only needed in
> > perf probe command. But the add functionality itself can be used by
> > other places. So move the printing code into the cmd_probe().
> >
> > The output is not changed.
> >
>
> OK, I just have a comment below.
>
> > diff --git a/tools/perf/util/probe-event.h b/tools/perf/util/probe-event.h
> > index 610f743671e1..d491cf69f91b 100644
> > --- a/tools/perf/util/probe-event.h
> > +++ b/tools/perf/util/probe-event.h
> > @@ -144,6 +144,11 @@ extern int convert_perf_probe_events(struct perf_probe_event *pevs, int npevs);
> > extern int apply_perf_probe_events(struct perf_probe_event *pevs, int npevs);
> > extern void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs);
> > extern int del_perf_probe_events(struct strfilter *filter);
> > +
> > +extern int probe_file__get_events(int fd, struct strfilter *filter,
> > + struct strlist *plist);
> > +extern int probe_file__del_strlist(int fd, struct strlist *namelist);
>
> These should be moved into probe-file.h.

Right, will change!

Thanks,
Namhyung


>
> > +
> > extern int show_perf_probe_event(const char *group, const char *event,
> > struct perf_probe_event *pev,
> > const char *module, bool use_stdout);
>
> Thanks!
>

\
 
 \ /
  Last update: 2015-09-04 14:21    [W:0.060 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site