Messages in this thread | | | Date | Fri, 4 Sep 2015 20:52:36 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH 2/5] perf probe: Attach trace_probe_event with perf_probe_event |
| |
On Fri, Sep 04, 2015 at 11:36:56AM +0000, 平松雅巳 / HIRAMATU,MASAMI wrote: > > From: Namhyung Kim [mailto:namhyung@kernel.org]
Oh, this patch is came from Wang Nan. I missed to update the author, will change in v2.
> > > > This patch drops struct __event_package structure. Instead, it adds > > trace_probe_event into 'struct perf_probe_event'. > > > > trace_probe_event information gives further patches a chance to access > > actual probe points and actual arguments. Using them, perf probe can > > get whole list of added probes and print them at once. > > > > Other users like upcoming bpf_loader will be able to attach one bpf > > program to different probing points of an inline functions (which has > > multiple probing points) and glob functions. Moreover, by reading > > arguments information, bpf code for reading those arguments can be > > generated. > > Looks good to me. > > Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks Namhyung
| |