Messages in this thread | | | Subject | Re: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent" | From | Sergei Shtylyov <> | Date | Sun, 27 Sep 2015 16:02:40 +0300 |
| |
Hello.
On 9/27/2015 1:29 PM, Thomas Gleixner wrote:
>>> - d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI); >>> - if (!d) >>> - d = irq_find_host(msi_np); >>> - dev_set_msi_domain(dev, d); >>> + d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI); >>> + if (!d) >> >> if (!d) { >> >>> + d = irq_find_host(args.np); >>> + >>> + if (d) { >> >> } else { >> >>> + dev_set_msi_domain(dev, d); >>> + return; >>> + } > > Errm, no. How is that equivalent? > > Marc: > > d = foo(); > if (!d) > d = bar(); > if (d) { > bla(d); > return; > } > > Yours: > > d = foo(); > if (!d) { > d = bar(); > } else { > bla(d); > return; > } > > Hmm?
Ah, sorry, didn't notice the kind of assignment in the first branch. :-<
> Thanks, > tglx
MBR, Sergei
| |