lkml.org 
[lkml]   [2015]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] of: irq: Add support for the new definition of "msi-parent"
On Wed, 23 Sep 2015, Sergei Shtylyov wrote:
> > - d = irq_find_matching_host(msi_np, DOMAIN_BUS_PLATFORM_MSI);
> > - if (!d)
> > - d = irq_find_host(msi_np);
> > - dev_set_msi_domain(dev, d);
> > + d = irq_find_matching_host(args.np, DOMAIN_BUS_PLATFORM_MSI);
> > + if (!d)
>
> if (!d) {
>
> > + d = irq_find_host(args.np);
> > +
> > + if (d) {
>
> } else {
>
> > + dev_set_msi_domain(dev, d);
> > + return;
> > + }

Errm, no. How is that equivalent?

Marc:

d = foo();
if (!d)
d = bar();
if (d) {
bla(d);
return;
}

Yours:

d = foo();
if (!d) {
d = bar();
} else {
bla(d);
return;
}

Hmm?

Thanks,

tglx


\
 
 \ /
  Last update: 2015-09-27 13:01    [W:0.095 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site