lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ata:Check if D2H Register FIS command fails in the function ahci_do_softreset
On Fri, Sep 18, 2015 at 10:36:22PM -0400, Nicholas Krause wrote:
> This fixes the missing error check and handling if the second D2H
> register command fails in the function fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>

This isn't exactly a command execution and the success condition
checks are performed manually afterwards. The ignoring of command
execution result is intentional there and the proposed change is
likely to cause more harm than good. Unless there are specific cases
where the new code would behave better, I'd much rather leave it as it
is.

Thansk.

--
tejun


\
 
 \ /
  Last update: 2015-09-21 21:21    [W:0.047 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site