Messages in this thread | | | From | David Binderman <> | Subject | linux-4.2-rc6/drivers/extcon/extcon.c: 3 * bad tests ? | Date | Sun, 9 Aug 2015 21:30:24 +0000 |
| |
Hello there,
1.
[linux-4.2-rc6/drivers/extcon/extcon.c:153]: (style) Checking if unsigned variable 'id' is less than zero.
Source code is
id = find_cable_id_by_name(edev, name); if (id < 0)
but
unsigned int id;
Suggest sanity check return value from find_cable_id_by_name *before* assigning it into an unsigned variable.
2.
[linux-4.2-rc6/drivers/extcon/extcon.c:384]: (style) Checking if unsigned variable 'id' is less than zero.
Duplicate.
3.
[linux-4.2-rc6/drivers/extcon/extcon.c:432]: (style) Checking if unsigned variable 'id' is less than zero.
Another duplicate.
Regards
David Binderman
| |