lkml.org 
[lkml]   [2015]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCHv3 0/5] Fix compound_head() race
Date
Here's my attempt on fixing recently discovered race in compound_head().
It should make compound_head() reliable in all contexts.

The patchset is against Linus' tree. Let me know if it need to be rebased
onto different baseline.

It's expected to have conflicts with my page-flags patchset and probably
should be applied before it.

v3:
- Fix build without hugetlb;
- Drop page->first_page;
- Update comment for free_compound_page();
- Use 'unsigned int' for page order;

v2: Per Hugh's suggestion page->compound_head is moved into third double
word. This way we can avoid memory overhead which v1 had in some
cases.

This place in struct page is rather overloaded. More testing is
required to make sure we don't collide with anyone.

Kirill A. Shutemov (5):
mm: drop page->slab_page
zsmalloc: use page->private instead of page->first_page
mm: pack compound_dtor and compound_order into one word in struct page
mm: make compound_head() robust
mm: use 'unsigned int' for page order

Documentation/vm/split_page_table_lock | 4 +-
arch/xtensa/configs/iss_defconfig | 1 -
include/linux/mm.h | 82 +++++++++++-----------------------
include/linux/mm_types.h | 21 ++++++---
include/linux/page-flags.h | 80 ++++++++-------------------------
mm/Kconfig | 12 -----
mm/debug.c | 5 ---
mm/huge_memory.c | 3 +-
mm/hugetlb.c | 35 +++++++--------
mm/internal.h | 8 ++--
mm/memory-failure.c | 7 ---
mm/page_alloc.c | 76 ++++++++++++++++++-------------
mm/swap.c | 4 +-
mm/zsmalloc.c | 11 +++--
14 files changed, 133 insertions(+), 216 deletions(-)

--
2.5.0



\
 
 \ /
  Last update: 2015-08-19 11:41    [W:0.192 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site