Messages in this thread Patch in this message | | | From | Arjun Krishna Babu <> | Subject | [PATCH] staging: dgnc: Replace macro with flow control statement by a function | Date | Sun, 5 Jul 2015 23:46:28 +0530 |
| |
This patch fixes the checkpatch.pl warning:
WARNING: Macros with flow control statements should be avoided
Replace the macro with a function doing the exact same task as the macro.
Signed-off-by: Arjun Krishna Babu <arjunkrishnababu96@gmail.com> --- drivers/staging/dgnc/dgnc_sysfs.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c index 44db870..8ab0922 100644 --- a/drivers/staging/dgnc/dgnc_sysfs.c +++ b/drivers/staging/dgnc/dgnc_sysfs.c @@ -92,19 +92,17 @@ void dgnc_remove_driver_sysfiles(struct pci_driver *dgnc_driver) } -#define DGNC_VERIFY_BOARD(p, bd) \ - do { \ - if (!p) \ - return 0; \ - \ - bd = dev_get_drvdata(p); \ - if (!bd || bd->magic != DGNC_BOARD_MAGIC) \ - return 0; \ - if (bd->state != BOARD_READY) \ - return 0; \ - } while (0) - +static int DGNC_VERIFY_BOARD(struct device *p, struct dgnc_board *bd) +{ + if (!p) + return 0; + bd = dev_get_drvdata(p); + if (!bd || bd->magic != DGNC_BOARD_MAGIC) + return 0; + if (bd->state != BOARD_READY) + return 0; +} static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute *attr, char *buf) -- 1.9.1
| |