Messages in this thread | | | Date | Tue, 28 Jul 2015 09:06:01 +0100 | From | Lee Jones <> | Subject | Re: [patch 8/9] mfd/ucb1x00: Prepare ucb1x00_irq for irq argument removal |
| |
On Mon, 13 Jul 2015, Thomas Gleixner wrote:
> irq is incremented for no value in the for loop. Remove it. > > Search and update was done with coccinelle and the invaluable help of > Julia Lawall. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Julia Lawall <Julia.Lawall@lip6.fr> > Cc: Jiang Liu <jiang.liu@linux.intel.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/ucb1x00-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> Index: tip/drivers/mfd/ucb1x00-core.c > =================================================================== > --- tip.orig/drivers/mfd/ucb1x00-core.c > +++ tip/drivers/mfd/ucb1x00-core.c > @@ -282,7 +282,7 @@ void ucb1x00_adc_disable(struct ucb1x00 > * SIBCLK to talk to the chip. We leave the clock running until > * we have finished processing all interrupts from the chip. > */ > -static void ucb1x00_irq(unsigned int irq, struct irq_desc *desc) > +static void ucb1x00_irq(unsigned int __irq, struct irq_desc *desc) > { > struct ucb1x00 *ucb = irq_desc_get_handler_data(desc); > unsigned int isr, i; > @@ -292,7 +292,7 @@ static void ucb1x00_irq(unsigned int irq > ucb1x00_reg_write(ucb, UCB_IE_CLEAR, isr); > ucb1x00_reg_write(ucb, UCB_IE_CLEAR, 0); > > - for (i = 0; i < 16 && isr; i++, isr >>= 1, irq++) > + for (i = 0; i < 16 && isr; i++, isr >>= 1) > if (isr & 1) > generic_handle_irq(ucb->irq_base + i); > ucb1x00_disable(ucb); > >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |