Messages in this thread | | | Date | Tue, 28 Jul 2015 09:05:25 +0100 | From | Lee Jones <> | Subject | Re: [patch 5/9] mfd/t7l66xb: Consolidate chained IRQ handler install/remove |
| |
On Mon, 13 Jul 2015, Thomas Gleixner wrote:
> Chained irq handlers usually set up handler data as well. We now have > a function to set both under irq_desc->lock. Replace the two calls > with one. > > Search and conversion was done with coccinelle. > > Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Julia Lawall <Julia.Lawall@lip6.fr> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/t7l66xb.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
> Index: tip/drivers/mfd/t7l66xb.c > =================================================================== > --- tip.orig/drivers/mfd/t7l66xb.c > +++ tip/drivers/mfd/t7l66xb.c > @@ -252,8 +252,7 @@ static void t7l66xb_attach_irq(struct pl > } > > irq_set_irq_type(t7l66xb->irq, IRQ_TYPE_EDGE_FALLING); > - irq_set_handler_data(t7l66xb->irq, t7l66xb); > - irq_set_chained_handler(t7l66xb->irq, t7l66xb_irq); > + irq_set_chained_handler_and_data(t7l66xb->irq, t7l66xb_irq, t7l66xb); > } > > static void t7l66xb_detach_irq(struct platform_device *dev) > @@ -263,8 +262,7 @@ static void t7l66xb_detach_irq(struct pl > > irq_base = t7l66xb->irq_base; > > - irq_set_chained_handler(t7l66xb->irq, NULL); > - irq_set_handler_data(t7l66xb->irq, NULL); > + irq_set_chained_handler_and_data(t7l66xb->irq, NULL, NULL); > > for (irq = irq_base; irq < irq_base + T7L66XB_NR_IRQS; irq++) { > #ifdef CONFIG_ARM > >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |