Messages in this thread | | | Date | Tue, 9 Jun 2015 08:55:27 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 3/8] mfd: wm831x-auxadc: Pass the IRQF_ONESHOT flag |
| |
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/mfd/wm831x-auxadc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/wm831x-auxadc.c b/drivers/mfd/wm831x-auxadc.c > index 6ee3018..fd789d2 100644 > --- a/drivers/mfd/wm831x-auxadc.c > +++ b/drivers/mfd/wm831x-auxadc.c > @@ -285,7 +285,8 @@ void wm831x_auxadc_init(struct wm831x *wm831x) > > ret = request_threaded_irq(wm831x_irq(wm831x, > WM831X_IRQ_AUXADC_DATA), > - NULL, wm831x_auxadc_irq, 0, > + NULL, wm831x_auxadc_irq, > + IRQF_ONESHOT, > "auxadc", wm831x); > if (ret < 0) { > dev_err(wm831x->dev, "AUXADC IRQ request failed: %d\n",
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |