Messages in this thread | | | Date | Tue, 9 Jun 2015 08:55:05 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 2/8] mfd: mc13xxx-core: Pass the IRQF_ONESHOT flag |
| |
On Sat, 16 May 2015, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject > bogus threaded irq requests") threaded IRQs without a primary handler > need to be requested with IRQF_ONESHOT, otherwise the request will fail. > > So pass the IRQF_ONESHOT flag in this case. > > The semantic patch that makes this change is available > in scripts/coccinelle/misc/irqf_oneshot.cocci. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > --- > drivers/mfd/mc13xxx-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c > index 25fd711..3f9f4c8 100644 > --- a/drivers/mfd/mc13xxx-core.c > +++ b/drivers/mfd/mc13xxx-core.c > @@ -163,7 +163,7 @@ int mc13xxx_irq_request(struct mc13xxx *mc13xxx, int irq, > int virq = regmap_irq_get_virq(mc13xxx->irq_data, irq); > > return devm_request_threaded_irq(mc13xxx->dev, virq, NULL, handler, > - 0, name, dev); > + IRQF_ONESHOT, name, dev); > } > EXPORT_SYMBOL(mc13xxx_irq_request); >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |