Messages in this thread | | | Date | Thu, 4 Jun 2015 23:28:57 +0100 | From | Al Viro <> | Subject | Re: [RFC/PATCH 5/8] drivers/base/core.c: Use strreplace |
| |
On Thu, Jun 04, 2015 at 11:37:12AM +0200, Rasmus Villemoes wrote: > This eliminates a local variable and a little .text.
Hmm...
> *tmp = kstrdup(dev_name(dev), GFP_KERNEL); > if (!*tmp) > return NULL; > - while ((s = strchr(*tmp, '!'))) > - s[0] = '/'; > + strreplace((char *)*tmp, '!', '/'); > return *tmp;
That cast isn't nice. Why not make it s = kstrdup(...) if (s) strreplace(s, ...) return *tmp = s; instead?
| |