lkml.org 
[lkml]   [2015]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC/PATCH 1/8] lib: string: Introduce strreplace
From
Date
On Thu, 2015-06-04 at 23:37 +0100, Al Viro wrote:
> On Thu, Jun 04, 2015 at 03:56:07AM -0700, Joe Perches wrote:
> > Seems sensible, but the name maybe could be be more
> > explicit as strreplace seems like it should more like
> > a string substitution rather than a char substitution.
> >
> > Maybe strsubstchr or something like it (strtranschr?)
>
> Why not go the full monty and call it strtrtsstrrrtst(), with
> strtrtssstrrtst() doing almost, but not quite the same thing?

Presumably the extra r is for reverse and the
extra s in for insensitive, just because...

Naming does matter. Consistency too.

And for the consistency bit, the char arguments
should probably be int.




\
 
 \ /
  Last update: 2015-06-05 01:01    [W:0.061 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site