Messages in this thread | | | Date | Wed, 24 Jun 2015 00:03:12 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 09/27] perf stat: Introduce perf_counts function |
| |
On Tue, Jun 23, 2015 at 06:11:54PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 23, 2015 at 12:36:10AM +0200, Jiri Olsa escreveu: > > Introducing perf_counts function, that returns > > 'struct perf_counts_values' pointer for given cpu. > > - evsel->counts->cpu[cpu] = *count; > > + *perf_counts(evsel->counts, cpu) = *count; > > For consistency, just like thread_map__set_pid(), please have a:
it's consistent with xyarray__entry
> > perf_counts__set(evsel->counts, *cont); > > In addition to its counterpart: > > perf_counts__value(evsel->counts, cpu); > > Since you're not storing multiple entries per bucket, we need to use the > "value" idiom.
perf_counts returns pointer to the 'struct perf_counts_values' which is clean and valid and IMO the code is more readable
You use just 'perf_counts(counts, cpu, thread)' and get values and do whatever you want with them.. why introduce 2 functions for it?
thanks, jirka
| |