| Date | Tue, 23 Jun 2015 18:11:54 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 09/27] perf stat: Introduce perf_counts function |
| |
Em Tue, Jun 23, 2015 at 12:36:10AM +0200, Jiri Olsa escreveu: > Introducing perf_counts function, that returns > 'struct perf_counts_values' pointer for given cpu. > - evsel->counts->cpu[cpu] = *count; > + *perf_counts(evsel->counts, cpu) = *count;
For consistency, just like thread_map__set_pid(), please have a:
perf_counts__set(evsel->counts, *cont);
In addition to its counterpart:
perf_counts__value(evsel->counts, cpu);
Since you're not storing multiple entries per bucket, we need to use the "value" idiom.
- Arnaldo
|