lkml.org 
[lkml]   [2015]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/27] perf stat: Introduce perf_counts function
Em Tue, Jun 23, 2015 at 12:36:10AM +0200, Jiri Olsa escreveu:
> Introducing perf_counts function, that returns
> 'struct perf_counts_values' pointer for given cpu.
> - evsel->counts->cpu[cpu] = *count;
> + *perf_counts(evsel->counts, cpu) = *count;

For consistency, just like thread_map__set_pid(), please have a:

perf_counts__set(evsel->counts, *cont);

In addition to its counterpart:

perf_counts__value(evsel->counts, cpu);

Since you're not storing multiple entries per bucket, we need to use the
"value" idiom.

- Arnaldo


\
 
 \ /
  Last update: 2015-06-23 23:21    [W:0.269 / U:1.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site