| Date | Fri, 22 May 2015 13:49:46 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v4 11/13] staging: lnet: o2iblnd: checkpatch.pl fixes |
| |
On Thu, May 21, 2015 at 03:50:34PM -0400, Mike Shuey wrote: > @@ -2758,7 +2763,7 @@ void kiblnd_shutdown(lnet_ni_t *ni) > i = 2; > while (atomic_read(&net->ibn_npeers) != 0) { > i++; > - CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, /* 2**n? */ > + CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,/* 2**n? */
The original was better. I don't like this patch for the same reasons that people complained about patch 10. It does too many things as well.
regards, dan carpenter
|