lkml.org 
[lkml]   [2015]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes
From
Date
On Thu, 2015-05-21 at 15:50 -0400, Mike Shuey wrote:
> Fix many checkpatch.pl warnings.
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
[]
> @@ -99,38 +99,42 @@ lnet_connect_console_error(int rc, lnet_nid_t peer_nid,
> switch (rc) {
> /* "normal" errors */
> case -ECONNREFUSED:
> - CNETERR("Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> - libcfs_nid2str(peer_nid),
> - &peer_ip, peer_port);
> + CNETERR(
> + "Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> + libcfs_nid2str(peer_nid), &peer_ip, peer_port);

These are not improvements and checkpatch messages aren't dicta.

Please don't convert code unless the conversion makes it better
for a human reader.

These don't.




\
 
 \ /
  Last update: 2015-05-21 23:21    [W:0.209 / U:0.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site