lkml.org 
[lkml]   [2015]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/2] perf data: Show error message when ctf setup failed
Date
Show message when errors occurred during ctf conversion setup.

Before this patch:
$ ./perf data convert --to-ctf=ctf
$ echo $?
255

After this patch:
$ ./perf data convert --to-ctf=ctf
Error during CTF convert setup.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
tools/perf/util/data-convert-bt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index dd17c9a..a5b89b9 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -847,11 +847,15 @@ int bt_convert__perf2ctf(const char *input, const char *path, bool force)
(double) c.events_size / 1024.0 / 1024.0,
c.events_count);

- /* its all good */
-free_session:
perf_session__delete(session);
+ ctf_writer__cleanup(cw);
+
+ return err;

+free_session:
+ perf_session__delete(session);
free_writer:
ctf_writer__cleanup(cw);
+ pr_err("Error during CTF convert setup.\n");
return err;
}
--
2.3.3.220.g9ab698f


\
 
 \ /
  Last update: 2015-04-08 07:21    [W:0.102 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site