Messages in this thread | | | From | Liran Liss <> | Subject | RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() | Date | Fri, 24 Apr 2015 15:12:13 +0000 |
| |
> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > [snip] > a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { }; > > enum rdma_transport_type { > + /* legacy for users */ > RDMA_TRANSPORT_IB, > RDMA_TRANSPORT_IWARP, > RDMA_TRANSPORT_USNIC, > - RDMA_TRANSPORT_USNIC_UDP > + RDMA_TRANSPORT_USNIC_UDP, > + /* new transport */ > + RDMA_TRANSPORT_IBOE,
Remove RDMA_TRANSPORT_IBOE - it is not a transport. ROCE uses IBTA transport.
If any code should test for ROCE should invoke a specific helper, e.g., rdma_protocol_iboe(). This is what you currently call "rdma_tech_iboe" is patch 02/26.
I think that pretty much everybody agrees that rdma_protocol_*() is a better name than rdma_tech_*(), right? So, let's change this.
The semantics are: "check that a link supports a certain wire protocol, or a set of wire protocols", where 'certain' refers to the specific helper...
| |