Messages in this thread | | | Date | Sat, 7 Mar 2015 10:34:35 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 07/12] time: Try to catch clocksource delta underflows |
| |
* John Stultz <john.stultz@linaro.org> wrote:
> In the case where there is a broken clocksource > where there are multiple actual clocks that > aren't perfectly aligned, we may see small "negative" > deltas when we subtract now from cycle_last.
So this is a typical example where putting argument references is really helpful. Consider these two variants:
deltas when we subtract now from cycle_last.
deltas when we subtract 'now' from 'cycle_last'.
I had to read the first variant three times until I realized that 'now' is a C variable misleadingly inserted into English text.
> The values are actually negative with respect to the > clocksource mask value, not necessarily negative > if cast to a s64, but we can check by checking the > delta see if it is a small (relative to the mask) > negative value (again negative relative to the mask).
typo.
Thanks,
Ingo
| |