lkml.org 
[lkml]   [2015]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/12] clocksource: Simplify clocks_calc_max_nsecs logic

    * John Stultz <john.stultz@linaro.org> wrote:

    > The previous clocks_calc_max_nsecs had some unecessarily
    > complex bit logic to find the max interval that could cause
    > multiplication overflows. Since this is not in the hot
    > path, just do the divide to make it easier to read.
    >
    > The previous implementation also had a subtle issue
    > that it avoided overflows into signed 64bit values, where

    So here you write the weird '64bit' form, while in the code you write:

    > + * cyc2ns function without overflowing a 64-bit result.

    This repeats in later patches as well. I'd suggest using '64-bit'
    consistently throughout the whole series.

    > as the intervals are always unsigned. This resulted in
    > overly conservative intervals, which other saftey margins
    > were then added to, reducing the intended interval length.

    Typo.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2015-03-07 10:41    [W:2.200 / U:1.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site