lkml.org 
[lkml]   [2015]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers
From
Date
On Thu, 2015-03-12 at 12:51 -0300, Fabio Estevam wrote:
> On Thu, Mar 12, 2015 at 12:13 AM, Scott Wood <scottwood@freescale.com> wrote:
> > Use %pS for actual addresses, otherwise you'll get bad output
> > on arches like ppc64 where %pF expects a function descriptor.
>
> From Documentation/printk-formats.txt:
>
> "On ia64, ppc64 and parisc64 architectures function pointers are
> actually function descriptors which must first be resolved. The 'F' and
> 'f' specifiers perform this resolution and then provide the same
> functionality as the 'S' and 's' specifiers."
>
> ,so current code should work fine on ppc64, right?

No. __builtin_return_address() returns a pointer to an instruction, not
a function pointer descriptor. If you use %pF on the former, it'll
print instruction opcodes as if they were the address.

-Scott




\
 
 \ /
  Last update: 2015-03-12 18:01    [W:0.417 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site