Messages in this thread | | | Date | Thu, 12 Mar 2015 09:03:08 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 16/22] mfd: %pF is only for function pointers |
| |
On Wed, 11 Mar 2015, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. > > Signed-off-by: Scott Wood <scottwood@freescale.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/mc13xxx-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c > index 64dde5d..25fd711 100644 > --- a/drivers/mfd/mc13xxx-core.c > +++ b/drivers/mfd/mc13xxx-core.c > @@ -51,19 +51,19 @@ > void mc13xxx_lock(struct mc13xxx *mc13xxx) > { > if (!mutex_trylock(&mc13xxx->lock)) { > - dev_dbg(mc13xxx->dev, "wait for %s from %pf\n", > + dev_dbg(mc13xxx->dev, "wait for %s from %ps\n", > __func__, __builtin_return_address(0)); > > mutex_lock(&mc13xxx->lock); > } > - dev_dbg(mc13xxx->dev, "%s from %pf\n", > + dev_dbg(mc13xxx->dev, "%s from %ps\n", > __func__, __builtin_return_address(0)); > } > EXPORT_SYMBOL(mc13xxx_lock); > > void mc13xxx_unlock(struct mc13xxx *mc13xxx) > { > - dev_dbg(mc13xxx->dev, "%s from %pf\n", > + dev_dbg(mc13xxx->dev, "%s from %ps\n", > __func__, __builtin_return_address(0)); > mutex_unlock(&mc13xxx->lock); > }
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |