Messages in this thread | | | From | Alexandre Courbot <> | Date | Mon, 9 Feb 2015 14:24:22 +0900 | Subject | Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios |
| |
On Fri, Jan 30, 2015 at 10:46 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > <o.schinagl@ultimaker.com> wrote: > >> From: Olliver Schinagl <oliver@schinagl.nl> >> >> The gpio binding document says that new code should always use named >> gpios. Patch 40b73183 added support to parse a list of gpios from child >> nodes, but does not make it possible to use named gpios. This patch adds >> the con_id property and implements it is done in gpiolib.c, where the >> old-style of using unnamed gpios still works. >> >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> >> --- >> drivers/gpio/devres.c | 18 +++++++++++++++++- >> drivers/input/keyboard/gpio_keys_polled.c | 2 +- >> drivers/leds/leds-gpio.c | 2 +- >> include/linux/gpio/consumer.h | 1 + > > Alexandre: does this match your vision of how it should work, i.e. ACK?
Pretty much, yes - as I mentioned in the previous versions there may be shortcomings for ACPI, but we need a refactor of the whole thing - nothing that this patch should address by itself.
So this patch:
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |