Messages in this thread | | | Date | Fri, 30 Jan 2015 14:16:00 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios |
| |
On Fri, Jan 30, 2015 at 11:12:53AM -0800, Bryan Wu wrote: > On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > > <o.schinagl@ultimaker.com> wrote: > > > >> From: Olliver Schinagl <oliver@schinagl.nl> > >> > >> The gpio binding document says that new code should always use named > >> gpios. Patch 40b73183 added support to parse a list of gpios from child > >> nodes, but does not make it possible to use named gpios. This patch adds > >> the con_id property and implements it is done in gpiolib.c, where the > >> old-style of using unnamed gpios still works. > >> > >> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > >> --- > >> drivers/gpio/devres.c | 18 +++++++++++++++++- > >> drivers/input/keyboard/gpio_keys_polled.c | 2 +- > >> drivers/leds/leds-gpio.c | 2 +- > >> include/linux/gpio/consumer.h | 1 + > > > > Alexandre: does this match your vision of how it should work, i.e. ACK? > > > > Bryan/Dmitry: can you ACK the oneliners in your subsystems? > > Sure, please take my Ack > Acked-by: Bryan Wu <cooloney@gmail.com>
Mine as well:
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
-- Dmitry
| |