Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message | Date | Mon, 09 Feb 2015 00:28:35 +0100 |
| |
On Saturday, February 07, 2015 01:24:36 PM Dan Carpenter wrote: > Facts: > 1) None of these four error messages will ever be printed. > http://lwn.net/Articles/627419/ > 2) These messages are a waste of RAM.
So this is what the changelog should be saying, not that it "fixes checkpatch warnings".
checkpatch warnings in *existing* code are meaningless, unless they uncover a *real* problem in it which quite arguably this one is. But in those cases patch changelogs should talk about the *real* problems and they don't even need to mention checkpatch then as far as I'm concerned.
Send this one with a better changelog and I'll apply it.
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |