lkml.org 
[lkml]   [2015]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] drivers/base: Remove unnecessary OOM message
On Fri 2015-02-06 13:04:30, Joe Perches wrote:
> On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote:
> > On Fri 2015-02-06 16:39:12, Quentin Lambert wrote:
> > > This patch fix checkpatch warnings concerning the possible
> > > duplication of an "out of memory" message.
> >
> > So, instead of nice and readable "not enough memory for clock..." we
> > get OOM, stackdump, and backtrace...? Not sure it is improvement.
>
> All allocs without __GFP_NOWARN already gets an OOM and stackdump.
> These are just unnecessary.

"These" being human readable messages or ugly stackdumps?

Read what I have said. Figuring out what allocation failed from
unreliable backtrace is not fun.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2015-02-06 22:21    [W:0.039 / U:1.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site