Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFC][PATCH] module: Optimize __module_address() using a latched RB-tree | Date | Fri, 27 Feb 2015 22:32:39 +1030 |
| |
Peter Zijlstra <peterz@infradead.org> writes: > One of the users of this is __kernel_text_address() which is employed in > many stack unwinders; which in turn are used by perf-callchain (possibly > from NMI context).
Um, so the stack unwinders use "does this look like a kernel address" because we omit the frame pointer?
To keep that optimization, we add 220 non-trivial lines to module.c?
Don't get me wrong, it's cute code, but I do wonder if at some point a grown up is going to come along and tell us to stop :)
Cheers, Rusty.
| |