lkml.org 
[lkml]   [2015]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()
On 02/20/2015 09:51 PM, Fabian Frederick wrote:

>>> Use helper functions to access current->state.
>>> Direct assignments are prone to races and therefore buggy.

>>> current->state = TASK_RUNNING is replaced by __set_current_state()

>> You sometimes use __set_current_state() and sometimes set_current_state().

> Hello Sergei,

> Peter suggested to use __set_current_state() for TASK_RUNNING :
> http://marc.info/?l=linux-kernel&m=142442259719216&w=2

I didn't even question your decisions, I (like Peter) just wanted a more
coherent change-log. Thanks to Peter for the explanations though. :-)

> Regards,
> Fabian

>>> Thanks to Peter Zijlstra for the exact definition of the problem.

>>> Suggested-By: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Fabian Frederick <fabf@skynet.be>

>> [...]

WBR, Sergei



\
 
 \ /
  Last update: 2015-02-20 20:41    [W:0.068 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site