Messages in this thread | | | Subject | Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state() | From | Eric Dumazet <> | Date | Fri, 20 Feb 2015 11:44:37 -0800 |
| |
On Fri, 2015-02-20 at 11:31 -0800, Eric Dumazet wrote: > On Fri, 2015-02-20 at 19:58 +0100, Peter Zijlstra wrote: > > On Fri, Feb 20, 2015 at 09:34:28PM +0300, Sergei Shtylyov wrote: > > > Hello. > > > > > > On 02/20/2015 09:12 PM, Fabian Frederick wrote: > > > > > > >Use helper functions to access current->state. > > > >Direct assignments are prone to races and therefore buggy. > > > > > > >current->state = TASK_RUNNING is replaced by __set_current_state() > > > > > > You sometimes use __set_current_state() and sometimes set_current_state(). > > > > It depends on which state; setting yourself TASK_RUNNING is free of > > wakeup races -- you're already running after all, so it can safely use > > __set_current_state(). > > Maybe this might be self documented in set_current_state(), > as we have about 120 calls to __set_current_state(TASK_RUNNING)
And about 138 calls to set_current_state(TASK_RUNNING)
| |