Messages in this thread Patch in this message | | | From | Andreas Ruprecht <> | Subject | [PATCH] staging: lustre: osc: Fix sparse warning about osc_init | Date | Mon, 2 Feb 2015 14:36:43 +0100 |
| |
When running sparse on the osc/ subdirectory, it shows the following warning:
andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/ [...] drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: warning: symbol 'osc_init' was not declared. Should it be static? [...]
As this is the module init function, it can (and should) be declared static.
Signed-off-by: Andreas Ruprecht <rupran@einserver.de> --- drivers/staging/lustre/lustre/osc/osc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c index b9450b9..0adfa70 100644 --- a/drivers/staging/lustre/lustre/osc/osc_request.c +++ b/drivers/staging/lustre/lustre/osc/osc_request.c @@ -3332,7 +3332,7 @@ extern struct lu_kmem_descr osc_caches[]; extern spinlock_t osc_ast_guard; extern struct lock_class_key osc_ast_guard_class; -int __init osc_init(void) +static int __init osc_init(void) { struct lprocfs_static_vars lvars = { NULL }; int rc; -- 1.9.1
| |