| From | Arnd Bergmann <> | Subject | Re: [PATCH 45/45] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h | Date | Tue, 17 Feb 2015 10:10:42 +0100 |
| |
On Tuesday 17 February 2015 00:05:48 Mikko Rapeli wrote: > #ifndef __ASM_GENERIC_UCONTEXT_H > #define __ASM_GENERIC_UCONTEXT_H > > +#include <asm-generic/signal.h> > +#include <asm/sigcontext.h> > + > struct ucontext { >
Including another asm-generic header here is a bad idea: it breaks if an architecture overrides asm/signal.h with its own version but wants to use the asm-generic/ucontext.h file.
It would be best to just use linux/signal.h here, which includes the correct architecture specific files.
Arnd
|