lkml.org 
[lkml]   [2015]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/45] headers_install.sh: enhance error handling
On 2015-03-10 23:44, Mikko Rapeli wrote:
> On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote:
>> On 2015-02-17 00:05, Mikko Rapeli wrote:
>>> Exit with error if using undefined variables or if any sub command fails
>>> with error return value. unidef needs special handling since but this can
>>> be done without the trap. Enables exaniming intermediate files if some
>>> commands failed.
>>
>> The intermediate files are removed by your patch as well, aren't they?
>> Actually, I don't see any change in behavior after your patch.
>
> Yes, if everything succeeded without errors, then intermediate files
> are removed. But the files are left around if something fails

They are not:

+ "$SRCDIR/$i" > "$OUTDIR/$FILE.sed" || \
+ ( rm -f "$OUTDIR/$FILE.sed" ; exit 1 )

This removes "$OUTDIR/$FILE.sed" if the sed command files. Just like the
trap command has been doing.

Michal


\
 
 \ /
  Last update: 2015-03-11 11:21    [W:0.342 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site