Messages in this thread | | | From | "Du, Changbin" <> | Subject | RE: [PATCH 0/2] Two fix for dwc2 gadget driver | Date | Thu, 3 Dec 2015 04:23:09 +0000 |
| |
> On 11/29/2015 9:29 PM, changbin.du@intel.com wrote: > > From: "Du, Changbin" <changbin.du@intel.com> > > > > With the first patch, enable a enabled ep will return -EBUSY. > > The second patch forbid queuing on disabled ep to avoid panic. > > > The usb_ep->enabled flag was added in 4.4. > > It looks like these same checks are also added at the API level in the > usb_ep_enable() and usb_ep_disable(). > > In case this is bypassed we should probably add them in the gadget > anyways but using the existing flag. > > Regards, > John > Hmm, just learnt the flag on gadget API layer. And I just see usb_ep_enable return success if it is already enabled. But I think it should return an error to inform the caller. Because the ep configuration may probably be changed. In this case, usb_ep_enable will do different behavior.
Hmm, the usb_ep_queue doesn't check the enabled flag. Should be added. Let me have a try.
Best Regards, Changbin
| |