Messages in this thread | | | From | John Youn <> | Subject | Re: [PATCH 0/2] Two fix for dwc2 gadget driver | Date | Thu, 3 Dec 2015 01:20:56 +0000 |
| |
On 11/29/2015 9:29 PM, changbin.du@intel.com wrote: > From: "Du, Changbin" <changbin.du@intel.com> > > With the first patch, enable a enabled ep will return -EBUSY. > The second patch forbid queuing on disabled ep to avoid panic.
The usb_ep->enabled flag was added in 4.4.
It looks like these same checks are also added at the API level in the usb_ep_enable() and usb_ep_disable().
In case this is bypassed we should probably add them in the gadget anyways but using the existing flag.
Regards, John
> > Du, Changbin (2): > usb: dwc2: add ep enabled flag to avoid double enable/disable > usb: dwc2: forbid queuing request to a disabled ep > > drivers/usb/dwc2/core.h | 1 + > drivers/usb/dwc2/gadget.c | 26 +++++++++++++++++++++++++- > 2 files changed, 26 insertions(+), 1 deletion(-) >
| |