| Date | Mon, 14 Dec 2015 11:33:58 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH v3 10/17] perf: Provide subcmd configuration at runtime |
| |
On Sun, Dec 13, 2015 at 10:18:10PM -0600, Josh Poimboeuf wrote:
SNIP
> > typedef int (*config_fn_t)(const char *, const char *, void *); > extern int perf_default_config(const char *, const char *, void *); > diff --git a/tools/perf/util/exec_cmd.c b/tools/perf/util/exec_cmd.c > index 1099e92..84f9dc5 100644 > --- a/tools/perf/util/exec_cmd.c > +++ b/tools/perf/util/exec_cmd.c > @@ -5,19 +5,33 @@ > #include <string.h> > > #define MAX_ARGS 32 > +#define UNDEFINED "UNDEFINED" > > static const char *argv_exec_path; > static const char *argv0_path; > > +static const char *cfg_exec_name = UNDEFINED; > +static const char *cfg_prefix = UNDEFINED; > +static const char *cfg_exec_path = UNDEFINED; > +static const char *cfg_exec_path_env = UNDEFINED;
so instead of forcing each object to hold some subset of cfg_* configuration, why not create global cfg object that would carry this data.. cfg_path or so ;-)
jirka
|