Messages in this thread | | | Date | Mon, 14 Dec 2015 08:11:55 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v3 14/17] perf: Remove subcmd dependencies on strbuf |
| |
On Mon, Dec 14, 2015 at 11:25:51AM +0100, Jiri Olsa wrote: > On Sun, Dec 13, 2015 at 10:18:14PM -0600, Josh Poimboeuf wrote: > > Introduce and use new astrcat() and astrcatf() functions which replace > > the strbuf functionality for subcmd. > > hum, would it be better then to put strbuf into lib as well?
Based on the v2 discussion, I think we don't want to move it to lib, because it's also used by perf, and it's outside the scope of 'subcmd'.
But we could certainly duplicate it for internal use by the library.
Arnaldo, what do you think?
-- Josh
| |