Messages in this thread | | | Date | Wed, 4 Nov 2015 19:54:57 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] alarmtimer: fix unexpected rtc interrupt when system resume from S3 |
| |
Lee,
On Wed, 4 Nov 2015, Lee, Zhuo-hao wrote:
> Before the system go to suspend (S3), if user create a timer with clockid > CLOCK_REALTIME_ALARM/CLOCK_BOOTTIME_ALARM and set a "large" timeout value > to this timer. The function alarmtimer_suspend will be called to setup > a timeout value to RTC timer to avoid the system sleep over time. However, > if the system wakeup early than RTC timeout, the RTC timer will not be cleared. > And this will cause the hpet_rtc_interrupt come unexpectedly until the RTC > timeout. To fix this problem, just adding alarmtimer_resume to cancel the > RTC timer. > > Change-Id: I1db3948dd18ad20c25820e27f808da4511ddbf83
Can you please get rid of these Change-Ids? They carry no information which is useful in the kernel changelogs.
> Signed-off-by: Zhuo-hao Lee <zhuo-hao.lee@intel.com> > --- > kernel/time/alarmtimer.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c > index fe75444..7f7c8ea 100644 > --- a/kernel/time/alarmtimer.c > +++ b/kernel/time/alarmtimer.c > @@ -271,11 +271,25 @@ static int alarmtimer_suspend(struct device *dev) > __pm_wakeup_event(ws, MSEC_PER_SEC); > return ret;
That patch is white space damaged. Instead of 1 TAB it contains a random number of spaces. The Documentation directory has explanations how to setup your mail client proper, or just ask your co-workers.
Other than that, the patch looks correct.
Thanks,
tglx
| |