Messages in this thread | | | Subject | Re: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines | From | Joe Perches <> | Date | Wed, 25 Nov 2015 21:56:20 -0800 |
| |
On Wed, 2015-11-25 at 18:15 -0800, Shawn N wrote: > Hello, > > The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce > a minimum description when citing patches: 'commit <12+ chars of sha1> > (\"\")'. One (unintended?) consequence of this rule is > that unmodified 'cherry picked from commit ' (git cherry-pick > -x) lines are flagged. > > - Is the disallowing of 'cherry picked from commit ' lines by > GIT_COMMIT_ID working as intended? > - If yes, would it be acceptable to instead add a new rule with > clearer error output ("Don't include git cherry-pick -x description > lines")? > - If no (and such lines are actually acceptable) then I will just > patch the GIT_COMMIT_ID rule. > > Thanks, > > Shawn
I think sha1 commit ids should always be followed by a git commit description.
If that's not the general consensus, it's pretty easy to change.
| |