lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subjectcheckpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines
From
Hello,

The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
a minimum description when citing patches: 'commit <12+ chars of sha1>
(\"<title line>\")'. One (unintended?) consequence of this rule is
that unmodified 'cherry picked from commit <sha1>' (git cherry-pick
-x) lines are flagged.

- Is the disallowing of 'cherry picked from commit <sha1>' lines by
GIT_COMMIT_ID working as intended?
- If yes, would it be acceptable to instead add a new rule with
clearer error output ("Don't include git cherry-pick -x description
lines")?
- If no (and such lines are actually acceptable) then I will just
patch the GIT_COMMIT_ID rule.

Thanks,

Shawn


\
 
 \ /
  Last update: 2015-11-26 03:41    [W:0.038 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site