lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:

> + /* The mute state as set by alsa using the digital_mute callback */
> + bool alsa_mute_state;
> + /* The mute state as set by the userspace mute control */
> + bool control_mute_state;
> + /* The actual mute state is equal to an OR of the above */

Does the device *need* the digital mute to avoid noise? If there's no
strong need for it then just don't bother which simplifies the code a
lot.

Otherwise this looks good.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-25 14:21    [W:0.133 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site