Messages in this thread | | | From | "Hillf Danton" <> | Subject | Re: [RFC 2/3] mm: throttle on IO only when there are too many dirty and writeback pages | Date | Fri, 30 Oct 2015 12:18:50 +0800 |
| |
> --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3191,8 +3191,23 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > */ > if (__zone_watermark_ok(zone, order, min_wmark_pages(zone), > ac->high_zoneidx, alloc_flags, target)) { > - /* Wait for some write requests to complete then retry */ > - wait_iff_congested(zone, BLK_RW_ASYNC, HZ/50); > + unsigned long writeback = zone_page_state(zone, NR_WRITEBACK), > + dirty = zone_page_state(zone, NR_FILE_DIRTY); > + > + if (did_some_progress) > + goto retry; > + > + /* > + * If we didn't make any progress and have a lot of > + * dirty + writeback pages then we should wait for > + * an IO to complete to slow down the reclaim and > + * prevent from pre mature OOM > + */ > + if (2*(writeback + dirty) > reclaimable) > + congestion_wait(BLK_RW_ASYNC, HZ/10); > + else > + cond_resched(); > +
Looks the vmstat updater issue is not addressed. > goto retry; > } > } > -- > 2.6.1
| |