lkml.org 
[lkml]   [2015]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 2/3] mm: throttle on IO only when there are too many dirty and writeback pages
On Fri 30-10-15 12:18:50, Hillf Danton wrote:
>
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -3191,8 +3191,23 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
> > */
> > if (__zone_watermark_ok(zone, order, min_wmark_pages(zone),
> > ac->high_zoneidx, alloc_flags, target)) {
> > - /* Wait for some write requests to complete then retry */
> > - wait_iff_congested(zone, BLK_RW_ASYNC, HZ/50);
> > + unsigned long writeback = zone_page_state(zone, NR_WRITEBACK),
> > + dirty = zone_page_state(zone, NR_FILE_DIRTY);
> > +
> > + if (did_some_progress)
> > + goto retry;
> > +
> > + /*
> > + * If we didn't make any progress and have a lot of
> > + * dirty + writeback pages then we should wait for
> > + * an IO to complete to slow down the reclaim and
> > + * prevent from pre mature OOM
> > + */
> > + if (2*(writeback + dirty) > reclaimable)
> > + congestion_wait(BLK_RW_ASYNC, HZ/10);
> > + else
> > + cond_resched();
> > +
>
> Looks the vmstat updater issue is not addressed.

This is not the aim of this patch set.
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2015-10-30 09:41    [W:1.771 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site