lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging:drivers:wlan_ng: code style issues
On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote:
> On 10/26, Bogicevic Sasa wrote:
> >Thanks for the review just sent the new patch,
> >since change is very trivial I believe one liner like "fix all coding
> >style issues in that and that file" is descriptive enough.

No, not at all, that's not how we make kernel changes, look in the logs
for specifics. Each patch needs to be descriptive and only do one
thing. And as I said before "fix all coding style issues", is _NOT_
"one thing".

Please break it up into logical patches, _AND_ use checkpatch.pl to
properly send the patches to the correct mailing list and developers.

thanks,

greg k-h


\
 
 \ /
  Last update: 2015-10-27 01:21    [W:2.100 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site