lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging:drivers:wlan_ng: code style issues
On 10/26, Bogicevic Sasa wrote:
>Thanks for the review just sent the new patch,
>since change is very trivial I believe one liner like "fix all coding
>style issues in that and that file" is descriptive enough. Don't know the
>best practice so please be patient, I am new at this
>On 10/27, Greg KH wrote:
>>On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote:
>>>Fixed coding style issues
>>>Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
>>
>>What code style issues? Please be very specific. Also be sure you are
>>only doing one "thing" per patch, and no, "fix all coding style issues"
>>is not one thing...
>>
>>And we need a blank line before your signed-off-by: line.
>>
>>thanks,
>>
>>greg k-h


\
 
 \ /
  Last update: 2015-10-26 23:41    [W:0.054 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site