lkml.org 
[lkml]   [2015]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: possible new false positive in checkpatch
From
ping?
Is there a plan to fix it? should I send your fix? (kinda plagiarism)
next release? (which would mean the unnecessary warnings will exist in 4.3 :<)

On Tue, Sep 15, 2015 at 6:01 PM, Andy Whitcroft <apw@canonical.com> wrote:
> On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote:
>
>> > Yes it feels like that should be eliding them completely, and likely any
>> > following space as well, something like this:
>> >
>> > $s =~ s/$;+\s*//g;
>> > $c =~ s/$;+\s*//g;
>> >
>> Replacing the problematic lines with these fixes the issue.
>> > > Introduced in commit 9f5af480f4554aac12e002b6f5c2b04895857700:
>> > > checkpatch: improve SUSPECT_CODE_INDENT test
>> > > Commenting out these lines removes the warning.
>> > >
>> > > This pattern exists in many places around the kernel source.
>> > > Is this the intended behavior?
>> >
>> > Seems wrong to me.
>> >
>> > -apw
>>
>> Which git tree is checkpatch developed in? Linus's?
>
> Yeah in Linus' tree.
>
> -apw


\
 
 \ /
  Last update: 2015-10-26 18:01    [W:0.058 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site